Skip to content

[AI4SOC] Added support for the new promotion rule tag#228232

Merged
xcrzx merged 2 commits intoelastic:mainfrom
xcrzx:promotion-rule-tag-update
Jul 17, 2025
Merged

[AI4SOC] Added support for the new promotion rule tag#228232
xcrzx merged 2 commits intoelastic:mainfrom
xcrzx:promotion-rule-tag-update

Conversation

@xcrzx
Copy link
Copy Markdown
Contributor

@xcrzx xcrzx commented Jul 16, 2025

Summary

Added support for the new promotion rule tag as discussed here: elastic/detection-rules#4903 (comment).

For the time being, both the old Promotion tag and the new Promotion: External Alerts tag will be in use to avoid breaking changes. Once the promotion rules go live, we can remove support for the old tag.

@xcrzx xcrzx self-assigned this Jul 16, 2025
@xcrzx xcrzx requested review from a team as code owners July 16, 2025 14:10
@xcrzx xcrzx requested a review from maximpn July 16, 2025 14:10
@xcrzx xcrzx added backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area labels Jul 16, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 16, 2025

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #49 / Saved objects management should be able to handle multi-space imports correctly imported dashboard into default space should render correctly

History

cc @xcrzx

Copy link
Copy Markdown
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is trivial. LGTM

@xcrzx xcrzx merged commit ad56fe0 into elastic:main Jul 17, 2025
12 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16341023439

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 228232

Questions ?

Please refer to the Backport tool documentation

@xcrzx
Copy link
Copy Markdown
Contributor Author

xcrzx commented Jul 17, 2025

💚 All backports created successfully

Status Branch Result
9.1
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

xcrzx pushed a commit that referenced this pull request Jul 17, 2025
…#228410)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[AI4SOC] Added support for the new promotion rule tag
(#228232)](#228232)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Dmitrii
Shevchenko","email":"dmitrii.shevchenko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-17T09:09:52Z","message":"[AI4SOC]
Added support for the new promotion rule tag (#228232)\n\n##
Summary\n\nAdded support for the new promotion rule tag as discussed
here:\n[https://github.com/elastic/detection-rules/pull/4903#discussion\\_r2201961021](https://github.com/elastic/detection-rules/pull/4903#discussion_r2201961021).\n\nFor
the time being, both the old `Promotion` tag and the new
`Promotion:\nExternal Alerts` tag will be in use to avoid breaking
changes. Once the\npromotion rules go live, we can remove support for
the old tag.\n\nCo-authored-by: Maxim Palenov
<maxim.palenov@elastic.co>","sha":"ad56fe00fab80982ed8066bc5a5ef91cd2a5e0d4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Prebuilt
Detection
Rules","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[AI4SOC]
Added support for the new promotion rule
tag","number":228232,"url":"https://github.com/elastic/kibana/pull/228232","mergeCommit":{"message":"[AI4SOC]
Added support for the new promotion rule tag (#228232)\n\n##
Summary\n\nAdded support for the new promotion rule tag as discussed
here:\n[https://github.com/elastic/detection-rules/pull/4903#discussion\\_r2201961021](https://github.com/elastic/detection-rules/pull/4903#discussion_r2201961021).\n\nFor
the time being, both the old `Promotion` tag and the new
`Promotion:\nExternal Alerts` tag will be in use to avoid breaking
changes. Once the\npromotion rules go live, we can remove support for
the old tag.\n\nCo-authored-by: Maxim Palenov
<maxim.palenov@elastic.co>","sha":"ad56fe00fab80982ed8066bc5a5ef91cd2a5e0d4"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228232","number":228232,"mergeCommit":{"message":"[AI4SOC]
Added support for the new promotion rule tag (#228232)\n\n##
Summary\n\nAdded support for the new promotion rule tag as discussed
here:\n[https://github.com/elastic/detection-rules/pull/4903#discussion\\_r2201961021](https://github.com/elastic/detection-rules/pull/4903#discussion_r2201961021).\n\nFor
the time being, both the old `Promotion` tag and the new
`Promotion:\nExternal Alerts` tag will be in use to avoid breaking
changes. Once the\npromotion rules go live, we can remove support for
the old tag.\n\nCo-authored-by: Maxim Palenov
<maxim.palenov@elastic.co>","sha":"ad56fe00fab80982ed8066bc5a5ef91cd2a5e0d4"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 21, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
## Summary

Added support for the new promotion rule tag as discussed here:
[https://github.com/elastic/detection-rules/pull/4903#discussion\_r2201961021](https://github.com/elastic/detection-rules/pull/4903#discussion_r2201961021).

For the time being, both the old `Promotion` tag and the new `Promotion:
External Alerts` tag will be in use to avoid breaking changes. Once the
promotion rules go live, we can remove support for the old tag.

Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
## Summary

Added support for the new promotion rule tag as discussed here:
[https://github.com/elastic/detection-rules/pull/4903#discussion\_r2201961021](https://github.com/elastic/detection-rules/pull/4903#discussion_r2201961021).

For the time being, both the old `Promotion` tag and the new `Promotion:
External Alerts` tag will be in use to avoid breaking changes. Once the
promotion rules go live, we can remove support for the old tag.

Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

5 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @xcrzx

@xcrzx xcrzx removed the v8.19.0 label Aug 4, 2025
@xcrzx xcrzx deleted the promotion-rule-tag-update branch August 4, 2025 14:40
@xcrzx xcrzx removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants